Fix codecheck #332
Merged
Fix codecheck #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## ign-gui6 #332 +/- ##
============================================
- Coverage 66.71% 65.97% -0.75%
============================================
Files 26 34 +8
Lines 3221 4782 +1561
============================================
+ Hits 2149 3155 +1006
- Misses 1072 1627 +555
Continue to review full report at Codecov.
|
ahcorde
approved these changes
Dec 7, 2021
chapulina
added a commit
that referenced
this pull request
Dec 8, 2021
* Added log storing for ign-gui (#272) Signed-off-by: Nikhil Nair <nikhilnicky972@gmail.com> Signed-off-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Louise Poubel <louise@openrobotics.org> * Don't crash if a plugin has invalid QML (#315) Signed-off-by: Louise Poubel <louise@openrobotics.org> * Set marker point size from message (#317) Signed-off-by: Louise Poubel <louise@openrobotics.org> * Don't set visual scale for point markers (#321) Signed-off-by: Louise Poubel <louise@openrobotics.org> * Fix TopicEcho plugin message display (#322) - Change binding of width property in delegate (see: https://stackoverflow.com/questions/63767669/parent-is-null-in-listview-delegate-after-upgrade-to-qt-5-15) - Use scoped reference to model.display (see: https://forum.qt.io/topic/92085/using-qstringlistmodel-as-model-in-listview) Signed-off-by: Rhys Mainwaring <rhys.mainwaring@me.com> * Use qmldir to define QML module with IgnSpinBox (#319) Signed-off-by: William Wedler <william.wedler@resquared.com> Co-authored-by: Louise Poubel <louise@openrobotics.org> * Add PreRender event to MinimalScene (#325) Signed-off-by: Louise Poubel <louise@openrobotics.org> * Offer a way to disable warnings on marker manager (#326) Signed-off-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Fix codecheck (#329) Signed-off-by: Louise Poubel <louise@openrobotics.org> * Fix codecheck (#332) Signed-off-by: Louise Poubel <louise@openrobotics.org> * Grid config: set values from startup and improve layout (#324) Signed-off-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Nikhil Nair <43491351+NickNair@users.noreply.github.com> Co-authored-by: Rhys Mainwaring <rhys.mainwaring@me.com> Co-authored-by: Will <1305536+zflat@users.noreply.github.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Jenn Nguyen <jenn@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
Caught by auto-merge twice in a week 😬 (see #329). This one slipped through #326
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸